chore: remove @rspack/plugin-minify (#7307)

web-infra-dev · Jul 25, 2024 · ce81e75 · ce81e75 · rspack-bot · Jul 25, 2024
1 parent f9240d7
commit ce81e75
Show file tree

Hide file tree

Showing 17 changed files with 4 additions and 479 deletions.
diff --git a/packages/rspack-plugin-minify/LICENSE b/packages/rspack-plugin-minify/LICENSE
diff --git a/packages/rspack-plugin-minify/README.md b/packages/rspack-plugin-minify/README.md
diff --git a/packages/rspack-plugin-minify/package.json b/packages/rspack-plugin-minify/package.json
diff --git a/packages/rspack-plugin-minify/src/index.js b/packages/rspack-plugin-minify/src/index.js
diff --git a/packages/rspack-test-tools/package.json b/packages/rspack-test-tools/package.json
@@ -73,7 +73,6 @@
     "@monaco-editor/react": "^4.6.0",
     "@rspack/cli": "workspace:*",
     "@rspack/core": "workspace:*",
-    "@rspack/plugin-minify": "workspace:*",
     "@swc/plugin-remove-console": "^2.0.7",
     "@swc/helpers": "0.5.8",
     "@types/jsdom": "^21.1.7",

diff --git a/packages/rspack-test-tools/tests/configCases/plugins/minify-esbuild/index.js b/packages/rspack-test-tools/tests/configCases/plugins/minify-esbuild/index.js
diff --git a/packages/rspack-test-tools/tests/configCases/plugins/minify-esbuild/lib.js b/packages/rspack-test-tools/tests/configCases/plugins/minify-esbuild/lib.js
diff --git a/packages/rspack-test-tools/tests/configCases/plugins/minify-esbuild/rspack.config.js b/packages/rspack-test-tools/tests/configCases/plugins/minify-esbuild/rspack.config.js
diff --git a/packages/rspack-test-tools/tests/configCases/plugins/minify-terser/index.js b/packages/rspack-test-tools/tests/configCases/plugins/minify-terser/index.js
diff --git a/packages/rspack-test-tools/tests/configCases/plugins/minify-terser/lib.js b/packages/rspack-test-tools/tests/configCases/plugins/minify-terser/lib.js
diff --git a/packages/rspack-test-tools/tests/configCases/plugins/minify-terser/rspack.config.js b/packages/rspack-test-tools/tests/configCases/plugins/minify-terser/rspack.config.js
diff --git a/...es/rspack-test-tools/tests/configCases/plugins/minify-with-devtool-false/rspack.config.js b/...es/rspack-test-tools/tests/configCases/plugins/minify-with-devtool-false/rspack.config.js
@@ -1,4 +1,3 @@
-const minifyPlugin = require("@rspack/plugin-minify");
 const { SourceMapDevToolPlugin } = require('@rspack/core')
 
 /** @type {import("@rspack/core").Configuration} */
@@ -10,7 +9,6 @@ module.exports = {
 	},
 	optimization: {
 		minimize: true,
-		minimizer: [new minifyPlugin({})]
 	},
 	plugins: [
 		new SourceMapDevToolPlugin({})
suite	result
modernjs	❌ failure
_selftest	✅ success
nx	❌ failure
rspress	✅ success
rsbuild	❌ failure
examples	✅ success
Name	Base (2024-07-25 0436693)	Current	Change
10000_development-mode + exec	2.19 s ± 30 ms	2.2 s ± 30 ms	+0.56 %
10000_development-mode_hmr + exec	694 ms ± 15 ms	694 ms ± 8.2 ms	-0.05 %
10000_production-mode + exec	2.67 s ± 27 ms	2.71 s ± 40 ms	+1.30 %
arco-pro_development-mode + exec	1.9 s ± 53 ms	1.9 s ± 75 ms	+0.13 %
arco-pro_development-mode_hmr + exec	434 ms ± 1.6 ms	433 ms ± 2.7 ms	-0.01 %
arco-pro_production-mode + exec	3.48 s ± 85 ms	3.46 s ± 84 ms	-0.72 %
threejs_development-mode_10x + exec	1.76 s ± 28 ms	1.75 s ± 8.4 ms	-0.87 %
threejs_development-mode_10x_hmr + exec	858 ms ± 9 ms	863 ms ± 5.7 ms	+0.56 %
threejs_production-mode_10x + exec	5.7 s ± 38 ms	5.73 s ± 37 ms	+0.63 %