Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: panic "Run build_module hook failed" in compiler queue #5573

Closed
Tracked by #4327
Boshen opened this issue Feb 2, 2024 · 2 comments
Closed
Tracked by #4327

[Bug]: panic "Run build_module hook failed" in compiler queue #5573

Boshen opened this issue Feb 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.

Comments

@Boshen
Copy link
Contributor

Boshen commented Feb 2, 2024

What problem does this feature solve?

Should exit gracefully in webpack-test

const fileDeps = new webpack.util.LazySet();
const contextDeps = new webpack.util.LazySet();
const missingDeps = new webpack.util.LazySet();
const buildDeps = new webpack.util.LazySet();

Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  Run succeed_module hook failed: TypeError: webpack.util.LazySet is not a constructor

Location: crates/rspack_core/src/compiler/queue.rs:413

What does the proposed API of configuration look like?

.unwrap_or_else(|e| panic!("Run build_module hook failed: {}", e));

.unwrap_or_else(|e| panic!("Run succeed_module hook failed: {}", e));

@Boshen Boshen added the bug Something isn't working label Feb 2, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 2, 2024
@h-a-n-a h-a-n-a assigned LingyuCoder and unassigned h-a-n-a Feb 2, 2024
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Feb 2, 2024

@LingyuCoder Would you please have a look?

@Boshen Boshen changed the title rspack_core: return result instead of panic in compiler queue [Bug] rspack_core: panic in compiler queue Feb 2, 2024
@Boshen Boshen changed the title [Bug] rspack_core: panic in compiler queue [Bug]: panic "Run build_module hook failed" in compiler queue Feb 2, 2024
Copy link

stale bot commented Apr 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Apr 2, 2024
@hardfist hardfist closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

4 participants