Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking]: Testing against webpack core tests #4327

Closed
63 of 64 tasks
Tracked by #6689
ahabhgk opened this issue Oct 16, 2023 · 1 comment
Closed
63 of 64 tasks
Tracked by #6689

[Tracking]: Testing against webpack core tests #4327

ahabhgk opened this issue Oct 16, 2023 · 1 comment
Assignees
Labels
team The issue/pr is created by the member of Rspack. tracking issue Category: A tracking issue for an RFC or an unstable feature.
Milestone

Comments

@ahabhgk
Copy link
Contributor

ahabhgk commented Oct 16, 2023

Rspack is running webpack tests to discover current implementations and functionalities misaligned with webpack.

Our goal is to maintain consistency with webpack as much as possible, but there are still some features that require discussion to determine whether or not to support them. These include APIs that have alternative ECMAScript standards or features that have high support costs but are used by very few people. This issue is meant to track these inconsistencies, and we will continue to improve test coverage and pass rates in the future.

We have already run some tests at the moment. Of course, we welcome your help in advancing the testing progress and discovering any issues. This may require a certain level of familiarity with webpack's code to identify the underlying causes of test failures.

The following are the steps to advance the testing progress:

  1. Run pnpm run build:cli:debug or pnpm run build:cli:release to make sure you are on the latest build.
  2. cd webpack-test and find a test that you want to run.
  3. Make sure the test.filter.js under the test case is returning true.
  4. Run pnpm run test -- -t "test name", for example, if you want to run webpack-test/cases/amd/define-needs-module, you can use the following command pnpm run test -- -t "amd define-needs-module"
  5. If it passes, then you can remove test.filter.js under the test case.
  6. If it doesn't passes, then you need to find the reason why it failed, and make test.filter.js return a string that contain the reason, and it would be better to create a issue and use the link as the reason, for example module.exports = () => {return "https://github.com/web-infra-dev/rspack/issues/4313"}

And the principle is not to modify the code of webpack-test's test to make the test passes. Instead, focus on tracking all inconsistencies as much as possible.

Here are some of the identified issues:

Unsupported features

Preview Give feedback
  1. PR welcome feat good first issue team
  2. feat stale team
  3. PR welcome feat stale team
  4. feat
    ahabhgk
  5. stale team
  6. team
  7. rsbuild
    bvanjoi
  8. team
    h-a-n-a
  9. team
  10. stale team
    h-a-n-a
  11. team
    h-a-n-a
  12. team
    Boshen
  13. feat
  14. PR welcome feat stale team
  15. team
    SyMind

Parser hook/Compile time evaluation

Preview Give feedback
  1. bug stale team
  2. stale team
  3. stale team
    bvanjoi

TreeShaking/SideEffects

Preview Give feedback
  1. team
  2. team
    IWANABETHATGUY

SplitChunks

Preview Give feedback
  1. contrib: easy feat good first issue stale team
    JSerFeng
  2. contrib: has guidance good first issue team
    JSerFeng
  3. stale
    JSerFeng
  4. contrib: easy contrib: has guidance good first issue
    JSerFeng

CSS

Preview Give feedback
  1. stale team
    JSerFeng

Sourcemap

Preview Give feedback
  1. team
    SyMind

Output

Preview Give feedback
  1. stale team
    ahabhgk

Node API

Preview Give feedback
  1. stale team
  2. PR welcome feat stale team
  3. stale team

Dependency/Codegen

Preview Give feedback
  1. stale team
  2. team
    LingyuCoder
  3. team
  4. team
  5. rsbuild stale team
  6. stale team
  7. stale team
    ahabhgk
  8. team
  9. team
    bvanjoi
  10. stale team

Errors/Warnings inconsistent

Preview Give feedback
  1. contrib: easy good first issue stale team
    JSerFeng
  2. team
    LingyuCoder
  3. stale team
  4. bug team
  5. team
  6. team
  7. contrib: medium good first issue
    OceanPresentChao

ContextModule

Preview Give feedback
  1. team
    faga295
  2. team
    faga295
  3. stale team
  4. team
    ahabhgk
  5. stale team
    ahabhgk
  6. stale team
    bvanjoi
  7. team
  8. stale team

Test Infrastructure

Preview Give feedback
  1. A-build-testing team
@ahabhgk ahabhgk added the tracking issue Category: A tracking issue for an RFC or an unstable feature. label Oct 16, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 16, 2023
@h-a-n-a h-a-n-a changed the title [Tracking]: Against webpack-test [Tracking]: Testing against webpack-test Oct 26, 2023
@hardfist hardfist pinned this issue Nov 1, 2023
@h-a-n-a h-a-n-a changed the title [Tracking]: Testing against webpack-test [Tracking]: Testing against webpack core tests Feb 27, 2024
@h-a-n-a h-a-n-a added this to the 1.0.0 milestone Feb 29, 2024
@hardfist hardfist unpinned this issue Apr 26, 2024
@h-a-n-a h-a-n-a modified the milestones: 1.0.0, 1.1.0 Sep 19, 2024
@chenjiahan
Copy link
Member

I will close this tracking issue since we have a new tracking issue for webpack test cases: #8445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack. tracking issue Category: A tracking issue for an RFC or an unstable feature.
Projects
None yet
Development

No branches or pull requests

4 participants