You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds support for generating ES modules as output for the rspack bundler. It introduces new plugins, runtime modules, and output types to handle the module format and the dynamic import feature. It also enables tree shaking for the "module" output type and passes the entry module identifier to the plugins for more flexibility. It refactors some existing code and comments out some error checking for the AMD library name.
Add new output types and plugins for generating ES modules for chunks (link, link, link, link, link, link, link)
Enable tree shaking analysis for the "module" output type and make the results available for all configurations (link, link)
Pass the last entry module of the chunk to the render_startup hook of the plugins and use it to generate the startup code for the chunk (link, link, link, link, link, link, link)
Add new runtime modules for exporting the __webpack_require__ function and handling the chunk loading logic for the "module" and the "import" output types (link, link, link, link, link, link, link, link)
Enable the ModuleLibraryPlugin for the "module" output type and use the tree shaking analysis results to generate the export names for the entry module (link, link, link)
Enable the ModuleChunkFormatPlugin for the "module" output type and use the RuntimeGlobals::STARTUP_ENTRYPOINT global variable to store the entry point function for the chunk (link, link, link, link)
Enable the ModuleChunkLoadingPlugin for the "import" output type and use the get_runtime_chunk_path function to get the relative path to the runtime chunk (link, link, link, link, link)
Simplify the code for getting the relative path to the runtime chunk in the CommonJsChunkFormatPlugin by using the get_runtime_chunk_path function (link, link)
Move the property_access function from the assign_library_plugin.rs module to the utils.rs module and import it from there (link, link)
Comment out the normalize_name function in the utils.rs module to temporarily disable the error checking for the AMD library name (link)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Overall, LGTM. But it seems that you only used export_info, but hold the whole tree_shaking_result until the compilation is finished, this gonna consume a lot of unnecessary memory. I think this is alright to merge this pr and left the optimization in the future, but would you mind opening a new issue to track this?
* feat: output module
* fix: format
* fix: test
* fix: test
* fix: test
* fix: avoid add tree_shaking_result
* fix: test
* fix: test
* fix: test
* fix: test
siyou
pushed a commit
to siyou/rspack
that referenced
this pull request
May 14, 2023
* feat: output module
* fix: format
* fix: test
* fix: test
* fix: test
* fix: avoid add tree_shaking_result
* fix: test
* fix: test
* fix: test
* fix: test
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
underfin
requested review from
hardfist,
ahabhgk,
h-a-n-a and
hyf0
as code owners
Related issue (if exists)
close #2612
Summary
ConfigCase.template.jsto configCase test🤖 Generated by Copilot at 5a87e69
This pull request adds support for generating ES modules as output for the rspack bundler. It introduces new plugins, runtime modules, and output types to handle the module format and the dynamic import feature. It also enables tree shaking for the "module" output type and passes the entry module identifier to the plugins for more flexibility. It refactors some existing code and comments out some error checking for the AMD library name.
Walkthrough
🤖 Generated by Copilot at 5a87e69
render_startuphook of the plugins and use it to generate the startup code for the chunk (link, link, link, link, link, link, link)__webpack_require__function and handling the chunk loading logic for the "module" and the "import" output types (link, link, link, link, link, link, link, link)ModuleLibraryPluginfor the "module" output type and use the tree shaking analysis results to generate the export names for the entry module (link, link, link)ModuleChunkFormatPluginfor the "module" output type and use theRuntimeGlobals::STARTUP_ENTRYPOINTglobal variable to store the entry point function for the chunk (link, link, link, link)ModuleChunkLoadingPluginfor the "import" output type and use theget_runtime_chunk_pathfunction to get the relative path to the runtime chunk (link, link, link, link, link)CommonJsChunkFormatPluginby using theget_runtime_chunk_pathfunction (link, link)property_accessfunction from theassign_library_plugin.rsmodule to theutils.rsmodule and import it from there (link, link)normalize_namefunction in theutils.rsmodule to temporarily disable the error checking for the AMD library name (link)