chore: remove ./x and Makefile and replace them with npm scripts #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
team
Boshen
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Changing this enabled us to run tests on windows. https://github.com/web-infra-dev/rspack/actions/runs/4741450215/jobs/8419005640
IWANABETHATGUY
pushed a commit
that referenced
this pull request
Apr 19, 2023
siyou
pushed a commit
to siyou/rspack
that referenced
this pull request
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue (if exists)
Closes #2581
Summary
🤖 Generated by Copilot at 7ee40b0
Removed the
./xscript and replaced it withpnpmcommands in various files. Added a new script to check for multiple version dependencies in Rust crates.Walkthrough
🤖 Generated by Copilot at 7ee40b0
./xscript withpnpm -wto run commands on all workspace packages in workflows and documentation (link, link, link)package.jsonscripts to usepnpm -rorpnpm --filterto run commands on specific or all packages (link)scripts/check_rust_dependency.jsto check for multiple version dependencies in Rust crates and use it inlint:rsscript (link)Makefile,scripts/cmd.js, andx(link, link, link)