Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: built in progress plugin support profile option #3803

Merged
merged 12 commits into from
Oct 17, 2023
Merged

feat: built in progress plugin support profile option #3803

merged 12 commits into from
Oct 17, 2023

Conversation

faga295
Copy link
Contributor

@faga295 faga295 commented Jul 19, 2023 •
edited
Loading

Summary

Based on of original progress plugin, I integrate the original logic to progress_handler, and add a new default_handler to print the profile of progress.In the update_throttled function, I chose 50ms as throttle time, in webpack this time is 500ms, maybe this time should discuss.
image

Test Plan

@faga295 faga295 marked this pull request as ready for review July 20, 2023 16:26
@faga295 faga295 requested a review from a team July 20, 2023 16:26
@faga295 faga295 changed the title feat: support built in progress plugin feat: built in progress plugin support profile option Jul 20, 2023
@hardfist
Copy link
Contributor

@faga295 are you still working on this?

@faga295
Copy link
Contributor Author

faga295 commented Oct 13, 2023

Looks like it works now, but whether keep succeed_module still confused me

@hardfist hardfist requested a review from ahabhgk October 17, 2023 09:10
ahabhgk
ahabhgk approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahabhgk ahabhgk added this pull request to the merge queue Oct 17, 2023
Merged via the queue into web-infra-dev:main with commit 055a8e1 Oct 17, 2023
14 checks passed
@hardfist hardfist added the release: feature release: feature related release(mr only) label Oct 17, 2023
@faga295 faga295 mentioned this pull request Dec 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@faga295 faga295

Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faga295 @hardfist @ahabhgk