Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use self hosted ci #4360

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore: use self hosted ci #4360

merged 1 commit into from
Oct 19, 2023

Conversation

jerrykingxyz
Copy link
Collaborator

@jerrykingxyz jerrykingxyz commented Oct 18, 2023

Summary

fix build cache not work in CI and support use self hosted runner. Some CI data are as follows:

github action pr with self hosted
build rspack 23m4s 5m46s
build job 27m56s 9m42s
rust test 6m37s 3m13s
nodejs test 7m12s 5m43s
one time CI 39m14s 15m46s

This new runner can be toggled by the CI action variables LINUX_RUNNER_LABELS. See https://github.com/web-infra-dev/rspack/settings/variables/actions (permission required).

Test Plan

No

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 18, 2023
@hardfist
Copy link
Contributor

does it support fallback to github runner when self-hosted is down?

@jerrykingxyz
Copy link
Collaborator Author

No, github action does not support fallback, but i added some global variables to control it.

https://github.blog/changelog/2023-01-10-github-actions-support-for-configuration-variables-in-workflows/

@Boshen Boshen merged commit 7c363fc into main Oct 19, 2023
15 of 16 checks passed
@Boshen Boshen deleted the test-runner branch October 19, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants