Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update dependency #4361

Merged
merged 15 commits into from
Oct 20, 2023
Merged

feat: update dependency #4361

merged 15 commits into from
Oct 20, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Oct 19, 2023 •
edited
Loading

Summary

  1. port https://github.com/webpack/webpack/blob/87660921808566ef3b8796f8df61bd79fc026108/lib/optimize/SideEffectsFlagPlugin.js#L246-L317

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/update-dependency branch 2 times, most recently from a7dc7bd to 4b64a8a Compare October 19, 2023 08:03
@IWANABETHATGUY IWANABETHATGUY changed the title Feat/update dependency feat: update dependency Oct 19, 2023
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Oct 19, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review October 19, 2023 10:42
@IWANABETHATGUY IWANABETHATGUY requested review from a team October 19, 2023 10:42
@IWANABETHATGUY IWANABETHATGUY self-assigned this Oct 20, 2023
@IWANABETHATGUY @ahabhgk
Update crates/rspack_plugin_javascript/src/plugin/side_effects_flag_p…
aada47d 
…lugin.rs

Co-authored-by: Gengkun <ahabhgk@gmail.com>
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 75abf3e Oct 20, 2023
13 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/update-dependency branch October 20, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @ahabhgk