Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HarmonyExportImportedDependency get_exports #4388

Merged
merged 7 commits into from
Oct 23, 2023
Merged

fix: HarmonyExportImportedDependency get_exports #4388

merged 7 commits into from
Oct 23, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Oct 23, 2023 •
edited
Loading

Summary

  1. Adding missing API get_exports for HarmonyExportImportedDependency

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 23, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review October 23, 2023 03:36
@IWANABETHATGUY IWANABETHATGUY requested review from a team October 23, 2023 03:36
ahabhgk
ahabhgk previously approved these changes Oct 23, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Oct 23, 2023
@IWANABETHATGUY IWANABETHATGUY removed this pull request from the merge queue due to a manual request Oct 23, 2023
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit a19b474 Oct 23, 2023
13 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/get_target branch October 23, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @ahabhgk