feat: Error handling #549
Merged
feat: Error handling #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
changed the title
IWANABETHATGUY
force-pushed
the
feat/error-handling
branch
5 times, most recently
from
1f1db1a to
7437625
Compare
IWANABETHATGUY
commented
Aug 18, 2022
ga . BREAKING CHANGE: 🧨 git cz
stats
IWANABETHATGUY
force-pushed
the
feat/error-handling
branch
from
7f9d605 to
10888b3
Compare
IWANABETHATGUY
requested review from
h-a-n-a and
hyf0
and removed request for
hyf0
|
@iheyunfei @hardfist |
h-a-n-a
reviewed
Aug 18, 2022
hyf0
approved these changes
Aug 19, 2022
h-a-n-a
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request only finishes the functionality of Error Handling, the fine-grined handing will improve in the future pull requests.
Show case
For a
file resolve error, let's see what's the difference between this pull request andnext branchnext branch
pr branch
The start and end offset of
TraceableError are not right for now, will improve in the next pr.Test Plan
Related issue (if exists)
.uwnrap()and using custom error type instead ofanyhow#527Future reading