Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not eval exports in harmony #6883

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix: should not eval exports in harmony #6883

merged 2 commits into from
Jun 21, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jun 21, 2024 •
edited by chenjiahan
Loading

Summary

close #6849

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from LingyuCoder June 21, 2024 07:27
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 04fb6b5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66752d3d563887000819f1af

@ahabhgk ahabhgk enabled auto-merge (squash) June 21, 2024 07:52
@ahabhgk ahabhgk merged commit bc831ad into main Jun 21, 2024
29 checks passed
@ahabhgk ahabhgk deleted the fix-eval-exports-in-harmony branch June 21, 2024 07:55
@ahabhgk ahabhgk mentioned this pull request Jun 21, 2024
Closed
ahabhgk added a commit that referenced this pull request Jun 24, 2024
@ahabhgk
fix: should not eval exports in harmony (#6883)
4890082
@ahabhgk ahabhgk mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyMind SyMind SyMind approved these changes

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

Assignees

@ahabhgk ahabhgk

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Uncaught ReferenceError: exports is not defined
2 participants
@ahabhgk @SyMind