Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nwjs external preset #6907

Merged
merged 6 commits into from
Jun 25, 2024
Merged

feat: add nwjs external preset #6907

merged 6 commits into from
Jun 25, 2024

Conversation

wxiaoyun
Copy link
Contributor

@wxiaoyun wxiaoyun commented Jun 25, 2024 •
edited
Loading

Summary

Add nwjs external presets to config

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 2840cc8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667a94f7c20cfa0008f11234

@h-a-n-a h-a-n-a requested a review from ahabhgk June 25, 2024 06:31
ahabhgk
ahabhgk requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add defaults

rspack/packages/rspack/src/config/defaults.ts

Lines 829 to 833 in 089726b

D(
externalsPresets,
"electron",
targetProperties && targetProperties.electron
);

@wxiaoyun wxiaoyun requested a review from ahabhgk June 25, 2024 08:15
ahabhgk
ahabhgk previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wxiaoyun wxiaoyun force-pushed the feat/add-nwjs-external-preset branch from 6dfe5e8 to d3f96f5 Compare June 25, 2024 09:22
@wxiaoyun wxiaoyun force-pushed the feat/add-nwjs-external-preset branch from d3f96f5 to 2840cc8 Compare June 25, 2024 09:59
@wxiaoyun wxiaoyun requested a review from ahabhgk June 25, 2024 10:00
@ahabhgk ahabhgk merged commit 691a4f3 into web-infra-dev:main Jun 25, 2024
31 checks passed
@wxiaoyun wxiaoyun deleted the feat/add-nwjs-external-preset branch June 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxiaoyun @ahabhgk