Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove fields of SwcJsMinimizerRspackPluginOptions #6950

Merged
merged 2 commits into from
Jun 27, 2024
Merged

feat: remove fields of SwcJsMinimizerRspackPluginOptions #6950

merged 2 commits into from
Jun 27, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jun 27, 2024 •
edited
Loading

Summary

Aligned all fields with swc minification options: https://swc.rs/docs/configuration/minification#jscminifyformat

Removed options for SwcJsMinimizerRspackPluginOptions:

  • options.passes: moved to options.compress.passes
  • options.dropConsole: moved to options.compress.drop_console
  • options.pureFuncs: moved to options.compress.pure_funcs
  • options.keepClassNames: moved to options.mangle.keep_classnames
  • options.keepFnNames: moved to options.mangle.keep_fnames
  • options.comments: moved to options.format.comments
  • options.asciiOnly: moved to options.format.ascii_only

Default value changes:

  • comments (options.format.comments): changed from false to "some"

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@h-a-n-a h-a-n-a added the release: breaking change release: breaking change related release(mr only) label Jun 27, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jun 27, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit dd2519d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667d1072d1dc700008a1e692

@h-a-n-a h-a-n-a enabled auto-merge (squash) June 27, 2024 07:25
@h-a-n-a h-a-n-a merged commit 8febf11 into main Jun 27, 2024
43 checks passed
@h-a-n-a h-a-n-a deleted the feat/remove-swc-js-minizier-opitons branch June 27, 2024 07:31
@hardfist
Copy link
Contributor

this seems contains breaking change, should contains breaking change notice and use feat! in title

@h-a-n-a h-a-n-a mentioned this pull request Jun 28, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-a-n-a @hardfist @LingyuCoder