-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: set default value of concatenateModules to true in production mode #6959
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["10000_production-mode + exec","arco-pro_production-mode + exec","threejs_production-mode_10x + exec"] |
!eco-ci |
e1ad14d
to
fce7169
Compare
!bench |
⏳ Triggered benchmark: Open |
f9da6b8
to
fb655d7
Compare
!bench |
📝 Benchmark detail: Open
Threshold exceeded: ["10000_production-mode + exec","arco-pro_production-mode + exec","threejs_production-mode_10x + exec"] |
the performance regression seems huge |
fb655d7
to
8d57c6b
Compare
!bench |
📝 Benchmark detail: Open
|
Summary
Set optimization.concatenateModules to true in production mode by default
Checklist