Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): allow entry function to return promise #6975

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(config): allow entry function to return promise #6975

merged 1 commit into from
Jun 28, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Should allow entry function to return promise:

Screenshot 2024-06-28 at 16 03 30

see: https://www.rspack.dev/config/entry#dynamic-entry

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 28, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 7dde5a4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667e7275a3c3e00009d1225f
😎 Deploy Preview https://deploy-preview-6975--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 4cde701 into main Jun 28, 2024
34 checks passed
@chenjiahan chenjiahan deleted the entry_zod_0628 branch June 28, 2024 10:37
@chenjiahan chenjiahan mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9aoy 9aoy 9aoy approved these changes

Assignees

@chenjiahan chenjiahan

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @9aoy