Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: port inner graph #7043

Merged
merged 2 commits into from
Jul 8, 2024
Merged

refactor: port inner graph #7043

merged 2 commits into from
Jul 8, 2024

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Jul 4, 2024

Summary

fix #7016

Implement InnerGraph using parser hook.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c9bae62
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668b8854c9d7950008e5e19c
😎 Deploy Preview https://deploy-preview-7043--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 4, 2024
@JSerFeng JSerFeng force-pushed the refactor/inner-graph branch 2 times, most recently from 17ee213 to 66572fb Compare July 4, 2024 12:04
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Jul 4, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Jul 4, 2024

📝 Benchmark detail: Open

Name Base (2024-07-04 b05f523) Current Change
10000_development-mode + exec 2.14 s ± 20 ms 2.17 s ± 25 ms +1.55 %
10000_development-mode_hmr + exec 689 ms ± 5.8 ms 695 ms ± 5.2 ms +0.89 %
10000_production-mode + exec 2.76 s ± 25 ms 2.77 s ± 20 ms +0.36 %
arco-pro_development-mode + exec 1.89 s ± 57 ms 1.91 s ± 83 ms +0.74 %
arco-pro_development-mode_hmr + exec 432 ms ± 2 ms 435 ms ± 1.7 ms +0.61 %
arco-pro_production-mode + exec 3.48 s ± 84 ms 3.46 s ± 44 ms -0.34 %
threejs_development-mode_10x + exec 1.6 s ± 15 ms 1.57 s ± 10 ms -1.71 %
threejs_development-mode_10x_hmr + exec 820 ms ± 8.5 ms 801 ms ± 8.6 ms -2.33 %
threejs_production-mode_10x + exec 5.58 s ± 47 ms 5.58 s ± 24 ms -0.13 %

@JSerFeng JSerFeng force-pushed the refactor/inner-graph branch from 66572fb to 255e00e Compare July 4, 2024 12:24
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Jul 4, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Jul 4, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jul 8, 2024

Are we able to turn on this case?

@JSerFeng JSerFeng force-pushed the refactor/inner-graph branch from dc7edb0 to c9bae62 Compare July 8, 2024 06:33
@JSerFeng
Copy link
Collaborator Author

JSerFeng commented Jul 8, 2024

Are we able to turn on #5554 case?

Nope, this pr just port the visit logic of innerGraph

@ahabhgk ahabhgk merged commit c0e838d into main Jul 8, 2024
29 checks passed
@ahabhgk ahabhgk deleted the refactor/inner-graph branch July 8, 2024 07:33
@shulaoda shulaoda mentioned this pull request Dec 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: bad case of unused pure expression
4 participants