perf: optimize JS communication with lazy getters #7163
Merged
+375
−225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This optimization uses getters to lazily create JavaScript values in Rust.
This enhances performance, as illustrated by
JsStatsModule
. InJsStatsModule
, fields such asidentifier
,name
, andnameForCondition
are not always read. They are accessed only whenmodule.built
,module.codeGenerated
, oroptions.cachedModules
is true. Therefore, creating these JavaScript values in Rust when they are not used is unnecessary and inefficient.Below are the results for an internal project when
stats.all = true
:Before Optimization:
After Optimization:
Checklist