Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra/biome): rule noForEach #7266

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to issue #7182

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda requested a review from jerrykingxyz as a code owner July 22, 2024 21:12
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 08d3ae1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/669f233498dd2d00096cb2e7
😎 Deploy Preview https://deploy-preview-7266--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shulaoda shulaoda force-pushed the chore/biome-noForEach branch from 2732f10 to 08d3ae1 Compare July 23, 2024 03:27
@SoonIter SoonIter self-assigned this Jul 23, 2024
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@SoonIter SoonIter merged commit b6b4907 into web-infra-dev:main Jul 23, 2024
29 checks passed
@shulaoda shulaoda deleted the chore/biome-noForEach branch July 23, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants