test: move native loader test to rspack-test-tools
#7303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingyuCoder
approved these changes
Jul 25, 2024
colinaaa
commented
Jul 25, 2024
| @@ -4,7 +4,9 @@ module.exports = function () { | |||
| const callback = this.async(); | |||
|
|
|||
| this.resolve(__dirname, "./not-exist", (e1, r1) => { | |||
| assert(e1 instanceof Error); | |||
| // Note that e1 is not instanceof Error | |||
There was a problem hiding this comment.
I'm not sure if this is expected /cc @h-a-n-a
There was a problem hiding this comment.
@colinaaa This seems to be a known jest issue jestjs/jest#11808 and it turned out the assertion works outside of jest runner.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test of #4945 is put in
packages/rspack/testswhich is no longer running. Moving it intorspack-test-toolsand fix the test.Checklist