Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render filename with dollar sign #7402

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Aug 1, 2024

Summary

If filename contains dollar sign ($), output.filename renders to unexpected result, for example

FILENAME.replace_all(template, "foo$0")

the foo$0 is treat like a capture pattern, the '$0' is missing in the result

see https://docs.rs/regex/latest/regex/struct.Regex.html#replacement-string-syntax.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3d7be98
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66ab549421b74b00087233ca

ahabhgk
ahabhgk previously approved these changes Aug 1, 2024
@JSerFeng JSerFeng enabled auto-merge (squash) August 1, 2024 07:56
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 1, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 1, 2024
@LingyuCoder LingyuCoder mentioned this pull request Aug 1, 2024
2 tasks
@JSerFeng JSerFeng merged commit afbf8cd into main Aug 1, 2024
28 checks passed
@JSerFeng JSerFeng deleted the fix/filename-with-dollar-sign branch August 1, 2024 09:42
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants