Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stats perf degradation in hmr #7407

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Aug 1, 2024

Summary

fix: stats perf degradation in hmr

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SyMind
Copy link
Member Author

SyMind commented Aug 1, 2024

!bench

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a6293e2
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66ab5fd247c86000081a07ea

@rspack-bot
Copy link

rspack-bot commented Aug 1, 2024

📝 Benchmark detail: Open

Name Base (2024-08-01 2f6696e) Current Change
10000_development-mode + exec 2.24 s ± 26 ms 2.27 s ± 27 ms +1.56 %
10000_development-mode_hmr + exec 699 ms ± 9.2 ms 719 ms ± 10 ms +2.83 %
10000_production-mode + exec 2.79 s ± 22 ms 2.82 s ± 25 ms +1.03 %
arco-pro_development-mode + exec 1.9 s ± 77 ms 1.91 s ± 79 ms +0.64 %
arco-pro_development-mode_hmr + exec 432 ms ± 3 ms 433 ms ± 3.8 ms +0.35 %
arco-pro_production-mode + exec 3.39 s ± 64 ms 3.41 s ± 101 ms +0.59 %
threejs_development-mode_10x + exec 1.77 s ± 19 ms 1.72 s ± 13 ms -2.82 %
threejs_development-mode_10x_hmr + exec 878 ms ± 10 ms 839 ms ± 7 ms -4.38 %
threejs_production-mode_10x + exec 5.49 s ± 37 ms 5.48 s ± 24 ms -0.25 %

@SyMind SyMind changed the title fix: unused to json call fix: stats perf degradation in hmr Aug 1, 2024
@SyMind SyMind marked this pull request as ready for review August 1, 2024 11:39
@SyMind SyMind merged commit 6a924fc into main Aug 1, 2024
39 checks passed
@SyMind SyMind deleted the fix-stats-perf-degradation-in-hmr branch August 1, 2024 11:45
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants