Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rspack_loader_lightningcss): customMedia camelCase option #7409

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Aug 1, 2024

Summary

closes #7399

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter requested a review from JSerFeng August 1, 2024 11:40
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e4467c5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66ac4d948182b00008485cb2
😎 Deploy Preview https://deploy-preview-7409--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 1, 2024
@Fitz6
Copy link

Fitz6 commented Aug 1, 2024

Other sub-option structures should also be renamed using camelCase. 😂

@chenjiahan chenjiahan merged commit f03a83b into web-infra-dev:main Aug 2, 2024
28 checks passed
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The camelCase sub-options for builtin:lightningcss-loader are invalid.
4 participants