fix: change some walk_block_statement to walk_statement
#7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
release: bug fix
CPunisher
changed the title
walk_statementwalk_block_statement to walk_statement
CPunisher
changed the title
walk_block_statement to walk_statementwalk_block_statement to walk_statement
CPunisher
force-pushed
the
fix/walk-ctor
branch
from
708d41b to
f961343
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
webpack only directly call
walkBlockStatementatwalkStatementandwalkClass(StaticBlock).The difference between calling directly and calling via
walk_statementis thatwalk_statementupdates thestatement_pathandprev_statementinenter_statement.Omitting to update
prev_statementresults inasi_safeerror, which causes an unexpected semicolon to be inserted after the comma in theSequentialStatement.closes #7397
Checklist