fix: remove useless "module" external runtime #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
|
rebased main, ci error is fixed on main branch |
fi3ework
force-pushed
the
remove-external
branch
from
61326ca to
912da17
Compare
JSerFeng
approved these changes
Aug 12, 2024
Merged
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code deleted in this pull request is located at here in webpack. However, the code will never be called in Rspack because it is not fully implemented. I am deleting it now to reduce the runtime code for Rslib, and we can reimplement it when we are ready.
Additionally, I attempted to delete the corresponding code in webpack, but no CI tests were broken.
Checklist