feat(core)!: change dojang default escape|unescape to lodash.template syntax #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
release: feature
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hardfist
changed the title
hardfist
added
the
release: breaking change
hardfist
changed the title
hardfist
force-pushed
the
fix-lodash-template
branch
from
32806a2 to
208a321
Compare
hardfist
commented
Aug 22, 2024
chenjiahan
reviewed
Aug 23, 2024
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
chenjiahan
previously approved these changes
Aug 23, 2024
LingyuCoder
previously approved these changes
Aug 23, 2024
chenjiahan
approved these changes
Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE:
Rspack's default template syntax is same as ejs and webpack's default template syntax is lodash.template, while rsbuild's default template syntax is same as lodash.template too.
This PR change Rspack's default template syntax about escape | unescape to lodash.template which is consistent with webpack | Rsbuild.
Checklist