Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve issue with external array not working in UMD libraryTarget #7675

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: resolve issue with external array not working in UMD libraryTarget #7675

merged 1 commit into from
Aug 26, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Aug 24, 2024

Summary

fix #7672

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 24, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 24, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 490a53e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c9a52882949c0008c57873

@chenjiahan chenjiahan requested review from ahabhgk and fi3ework August 26, 2024 02:20
ahabhgk
ahabhgk approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahabhgk ahabhgk merged commit 069c7f4 into web-infra-dev:main Aug 26, 2024
33 checks passed
@chenjiahan chenjiahan mentioned this pull request Aug 26, 2024
Merged
@inottn inottn deleted the fix/7672 branch September 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@fi3ework fi3ework Awaiting requested review from fi3ework

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: Cannot read properties of undefined (reading 'ReactCurrentDispatcher')
2 participants
@inottn @ahabhgk