Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): support function filename and [name] in filename #7753

Merged
merged 6 commits into from
Oct 28, 2024
Merged

feat(html): support function filename and [name] in filename #7753

merged 6 commits into from
Oct 28, 2024

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Sep 2, 2024 •
edited
Loading

Summary

  • Support function filename
  • Support filename with [name]

The filenames will be calculated from entries on JS side, then send them to Rust side. So dynamic entry is not supported.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 52056c0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671f418d0f23800008e7ecf3
😎 Deploy Preview https://deploy-preview-7753--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder LingyuCoder force-pushed the feat/html-dynamic-filename branch from 4360d2a to 7451b86 Compare September 2, 2024 04:48
@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Sep 2, 2024
@LingyuCoder LingyuCoder force-pushed the feat/html-dynamic-filename branch from 7451b86 to 5d785be Compare September 3, 2024 05:37
@LingyuCoder LingyuCoder added this to the 1.1.0 milestone Sep 12, 2024
@LingyuCoder LingyuCoder removed the release: breaking change release: breaking change related release(mr only) label Oct 28, 2024
@LingyuCoder LingyuCoder changed the title feat(html)!: support function filename and [name] in filename feat(html): support function filename and [name] in filename Oct 28, 2024
@LingyuCoder LingyuCoder force-pushed the feat/html-dynamic-filename branch from 5d785be to 957332a Compare October 28, 2024 07:32
@LingyuCoder LingyuCoder requested a review from ahabhgk October 28, 2024 08:23
@LingyuCoder LingyuCoder enabled auto-merge (squash) October 28, 2024 08:23
@LingyuCoder LingyuCoder merged commit 5b7653b into main Oct 28, 2024
33 checks passed
@LingyuCoder LingyuCoder deleted the feat/html-dynamic-filename branch October 28, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @ahabhgk