Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support LoaderContext.loadModule #7940

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Sep 20, 2024

Summary

closes #3738
closes #7723

TODOs or existing bugs to fix:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b52e30b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66ee760024d7f7000852b0b2

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Sep 20, 2024
@CPunisher
Copy link
Contributor Author

@h-a-n-a I have finished the basic implementation except the bugs above. It's more complex than I expect. One key point is to get original module info when importing/loading referenced modules in loaders. But from my inspect, the artifacts that contain module graphs are not shared between the task loop of ModuleExecutor and main task loop. Am I right?

@luhc228
Copy link
Contributor

luhc228 commented Sep 27, 2024

An exciting feature! I need this API, too.

@luhc228
Copy link
Contributor

luhc228 commented Oct 28, 2024

Any progress?

@chenjiahan
Copy link
Member

@h-a-n-a Can you take a look? ❤️

@CPunisher
Copy link
Contributor Author

@h-a-n-a Can you take a look? ❤️

I will hang on to the pr or close it because this is not a good implementation. See #8096.

Copy link

stale bot commented Dec 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").

@stale stale bot added the stale label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: support LoaderContext.loadModule Support loaderContext.loadModule
3 participants