Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape node.__dirname #8172

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Oct 19, 2024

Summary

fix #8170

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 19, 2024
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ecf58cd
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67138b89929edb0008b5757e

Copy link
Collaborator

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@LingyuCoder LingyuCoder merged commit e616982 into web-infra-dev:main Oct 20, 2024
34 checks passed
@inottn inottn deleted the fix/8170-node-dirname branch October 20, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: node.__dirname: true causes broken output on Windows
2 participants