Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use inlined args for format! #8228

Merged
merged 2 commits into from
Dec 26, 2024
Merged

style: use inlined args for format! #8228

merged 2 commits into from
Dec 26, 2024

Conversation

hamirmahal
Copy link
Contributor

Summary

Fixes #8227

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 343bc34
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676cc3660d6cce0008ab5299

hamirmahal
hamirmahal commented Oct 26, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request shouldn't cause any user-facing changes.

The goal here is to improve the codebase's maintainability and developer productivity.

@chenjiahan chenjiahan requested a review from h-a-n-a October 28, 2024 02:19
@h-a-n-a
Copy link
Contributor

h-a-n-a commented Oct 28, 2024

Style changes would be better with clippy rule changes. Would you please see if there's any rule can help us avoid regressions?

@hamirmahal
Copy link
Contributor Author

Sure!

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Dec 17, 2024

Would you mind me editing your PR to get it merged?

@h-a-n-a h-a-n-a force-pushed the style/simplify-statements-for-readability branch 2 times, most recently from f2d9b2b to ec98dbd Compare December 17, 2024 08:43
h-a-n-a
h-a-n-a previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@h-a-n-a h-a-n-a changed the title style: simplify statements for readability style: use inlined args for format! Dec 17, 2024
@h-a-n-a h-a-n-a enabled auto-merge (squash) December 17, 2024 08:46
@hamirmahal
Copy link
Contributor Author

You're welcome! Would you happen to know why https://github.com/web-infra-dev/rspack/actions/runs/12369367778/job/34524631512?pr=8228 is failing?

@LingyuCoder LingyuCoder force-pushed the style/simplify-statements-for-readability branch from ec98dbd to 48b6f43 Compare December 26, 2024 02:20
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 26, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8228 will not alter performance

Comparing hamirmahal:style/simplify-statements-for-readability (343bc34) with main (8dca41b)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@LingyuCoder
Copy link
Contributor

You're welcome! Would you happen to know why web-infra-dev/rspack/actions/runs/12369367778/job/34524631512?pr=8228 is failing?

We changed the rules of some workflows. So need to rebase the branch.

@h-a-n-a h-a-n-a merged commit 734ba4c into web-infra-dev:main Dec 26, 2024
32 checks passed
@hamirmahal hamirmahal deleted the style/simplify-statements-for-readability branch December 26, 2024 03:37
@h-a-n-a h-a-n-a mentioned this pull request Dec 26, 2024
Merged
2 tasks
h-a-n-a added a commit that referenced this pull request Dec 26, 2024
@h-a-n-a
chore: ignore style changes in git blame #8228 (#8852)
7707956 
chore: ignore style changes in git blame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@h-a-n-a h-a-n-a h-a-n-a left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some panic and other statements can be simplified
4 participants
@hamirmahal @CLAassistant @h-a-n-a @LingyuCoder