-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support output.compareBeforeEmit
#8245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
labels
Oct 29, 2024
LingyuCoder
commented
Oct 29, 2024
!bench |
📝 Benchmark detail: Open
|
SyMind
previously approved these changes
Oct 29, 2024
LingyuCoder
force-pushed
the
feat/compare-before-emit
branch
from
October 29, 2024 11:06
0b54a39
to
361f160
Compare
SyMind
approved these changes
Oct 29, 2024
Awesome, thank you very much. I'll test it on my setup ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Align with https://github.com/webpack/webpack/blob/main/lib/Compiler.js#L894-L924
Support
output.compareBeforeEmit
to avoid write same content to same file what will change the mtime of these files and trigger watcher behavior.Fix #8093
Checklist