Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve description, types and JSDoc for entry options #8361

Merged
merged 3 commits into from
Nov 7, 2024
Merged

feat: improve description, types and JSDoc for entry options #8361

merged 3 commits into from
Nov 7, 2024

Conversation

chenjiahan
Copy link
Member

Summary

  • Improve description, types and JSDoc for entry options
  • Reuse types between EntryDescription, EntryDescriptionNormalized and EntryOptions.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 92868dc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672b867e01f5e300080b66e6
😎 Deploy Preview https://deploy-preview-8361--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 6, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 6, 2024
@chenjiahan chenjiahan merged commit dfb5cf7 into main Nov 7, 2024
34 checks passed
@chenjiahan chenjiahan deleted the entry_options_1106 branch November 7, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiveMe-A-Name GiveMe-A-Name GiveMe-A-Name approved these changes

Assignees

@chenjiahan chenjiahan

Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @GiveMe-A-Name