Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(side effects): should optimize for same target export #8371

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix(side effects): should optimize for same target export #8371

merged 2 commits into from
Nov 8, 2024

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Nov 7, 2024

Summary

...

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 7, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 7, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5d38047
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672cb10e9eaadf0008891190

@ahabhgk ahabhgk enabled auto-merge (squash) November 7, 2024 11:57
@ahabhgk ahabhgk requested a review from JSerFeng November 7, 2024 12:23
@ahabhgk ahabhgk merged commit 1baa554 into main Nov 8, 2024
29 checks passed
@ahabhgk ahabhgk deleted the fix-same-target-export branch November 8, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

Assignees

@ahabhgk ahabhgk

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @JSerFeng