Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css runtime should have hmr handler when lazy-compilation #8400

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

JSerFeng
Copy link
Contributor

Summary

The hook runtimeRequirementInTree is different compared to webpack, we have current runtime_requirements represents current runtime_requirements, all_runtime_requirements represents all runtime_requirements, when insert a new RuntimeModule, the module should not depend on runtimeGlobals on runtime_requirements, it should use correct runtime_requirements at codegen phase

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 11, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 11, 2024
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d935118
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6731c846fc7b2a0008373d36

@JSerFeng JSerFeng force-pushed the fix/extract-css-runtime-requirements branch 2 times, most recently from 9674168 to 6122932 Compare November 11, 2024 08:57
@JSerFeng JSerFeng requested a review from ahabhgk November 11, 2024 08:57
ahabhgk
ahabhgk previously approved these changes Nov 11, 2024
@JSerFeng JSerFeng force-pushed the fix/extract-css-runtime-requirements branch from 6122932 to d935118 Compare November 11, 2024 09:03
@JSerFeng JSerFeng requested a review from ahabhgk November 11, 2024 10:04
@ahabhgk ahabhgk merged commit f23d638 into main Nov 11, 2024
29 checks passed
@ahabhgk ahabhgk deleted the fix/extract-css-runtime-requirements branch November 11, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants