Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement output.clean.keep: Option<string> #8479

Merged
merged 28 commits into from
Dec 3, 2024
Merged

feat: implement output.clean.keep: Option<string> #8479

merged 28 commits into from
Dec 3, 2024

Conversation

ClSlaid
Copy link
Contributor

@ClSlaid ClSlaid commented Nov 19, 2024 •
edited
Loading

Summary

Part of #7822

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ClSlaid
feat: implement output.clean.keep: Option<string>
fcc669e 
Signed-off-by: cl <cailue@apache.org>
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d2335fc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674edcbb22fcf70008a96e6b

@ClSlaid
Copy link
Contributor Author

ClSlaid commented Nov 20, 2024

/cc @h-a-n-a I wonder where I can add tests?

@inottn
Copy link
Collaborator

inottn commented Nov 20, 2024

You can write test cases under packages/rspack-test-tools/tests/configCases/clean/ignore-string.

@ClSlaid ClSlaid marked this pull request as draft November 23, 2024 19:57
@ClSlaid
patch: add test files
69103e2 
Signed-off-by: cl <cailue@apache.org>
@ClSlaid ClSlaid force-pushed the feat/webpack/output-clean branch 2 times, most recently from d699d3d to f123bd8 Compare November 23, 2024 20:11
@ClSlaid
patch: recover test files
9b0827b 
Signed-off-by: cl <cailue@apache.org>
@ClSlaid ClSlaid force-pushed the feat/webpack/output-clean branch from f123bd8 to 9b0827b Compare November 23, 2024 20:14
@ClSlaid
patch: rewrite datatype for clean
74d39be 
Signed-off-by: cl <cailue@apache.org>
ClSlaid
ClSlaid commented Nov 23, 2024
View reviewed changes
Copy link
Contributor Author

@ClSlaid ClSlaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @inottn help needed here.

crates/node_binding/binding.d.ts Outdated Show resolved Hide resolved
@ClSlaid ClSlaid marked this pull request as ready for review November 24, 2024 19:09
ClSlaid and others added 2 commits November 25, 2024 03:29
@ClSlaid
patch: fix-up simple clean test
c9ae7c6 
Signed-off-by: cl <cailue@apache.org>
@ClSlaid
patch: remove debug remains
703e5a5 
Signed-off-by: cailue <cailue@bupt.edu.cn>
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8479 will not alter performance

Comparing ClSlaid:feat/webpack/output-clean (d2335fc) with main (08ddcdd)

Summary

✅ 1 untouched benchmarks

@ClSlaid ClSlaid requested a review from inottn November 25, 2024 05:31
@inottn
Copy link
Collaborator

inottn commented Nov 25, 2024

Let's first ensure that the CI passes successfully.

@inottn
Copy link
Collaborator

inottn commented Nov 28, 2024

I'm not very familiar with fs and I'm unsure if it needs any changes. I'll assign this PR to someone who has a better understanding of it as a reviewer. cc @h-a-n-a

@ClSlaid
patch: remove unnecessary clone
e76c8e5 
Signed-off-by: cl <cailue@apache.org>
@ClSlaid
Copy link
Contributor Author

ClSlaid commented Nov 28, 2024

I'm afraid @h-a-n-a is kind of busy now? Even this PR is for an issue he was supposed to be assigned to.

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Nov 28, 2024

Will take a look later ;-)

@LingyuCoder LingyuCoder requested a review from h-a-n-a November 28, 2024 09:51
ClSlaid and others added 4 commits November 28, 2024 18:11
@ClSlaid
Copy link
Contributor Author

ClSlaid commented Dec 3, 2024

I think I need to learn more from the design of JsPath, it's sufficient for further development of output.clean.

@ClSlaid ClSlaid requested a review from LingyuCoder December 3, 2024 10:26
@LingyuCoder LingyuCoder enabled auto-merge (squash) December 3, 2024 12:47
@LingyuCoder
Copy link
Collaborator

Thanks

@LingyuCoder LingyuCoder merged commit 044e8e3 into web-infra-dev:main Dec 3, 2024
31 checks passed
@ClSlaid ClSlaid deleted the feat/webpack/output-clean branch December 4, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@inottn inottn Awaiting requested review from inottn

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ClSlaid @CLAassistant @inottn @h-a-n-a @LingyuCoder