Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: create tsfn error resolver once #8540

Merged
merged 1 commit into from
Nov 27, 2024
Merged

perf: create tsfn error resolver once #8540

merged 1 commit into from
Nov 27, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Nov 26, 2024

Summary

Reduce memory cost for tsfn error resolver

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d8fba3f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6745b41ff736e2000810a9e2

Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #8540 will not alter performance

Comparing perf-resolver (d8fba3f) with main (c1e8f11)

Summary

✅ 1 untouched benchmarks

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Nov 26, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Nov 26, 2024

📝 Benchmark detail: Open

Name Base (2024-11-26 b09e6b9) Current Change
10000_big_production-mode_disable-minimize + exec 40 s ± 958 ms 39.9 s ± 442 ms -0.30 %
10000_development-mode + exec 1.79 s ± 42 ms 1.77 s ± 25 ms -0.92 %
10000_development-mode_hmr + exec 644 ms ± 8.5 ms 642 ms ± 11 ms -0.18 %
10000_production-mode + exec 2.38 s ± 26 ms 2.38 s ± 18 ms -0.02 %
arco-pro_development-mode + exec 1.77 s ± 66 ms 1.75 s ± 103 ms -0.98 %
arco-pro_development-mode_hmr + exec 429 ms ± 1.7 ms 430 ms ± 1.2 ms +0.20 %
arco-pro_production-mode + exec 3.11 s ± 75 ms 3.12 s ± 77 ms +0.52 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.14 s ± 116 ms 3.15 s ± 73 ms +0.38 %
threejs_development-mode_10x + exec 1.61 s ± 12 ms 1.62 s ± 9.5 ms +0.27 %
threejs_development-mode_10x_hmr + exec 814 ms ± 11 ms 809 ms ± 10 ms -0.63 %
threejs_production-mode_10x + exec 4.89 s ± 30 ms 4.89 s ± 26 ms -0.04 %
10000_big_production-mode_disable-minimize + rss memory 12526 MiB ± 165 MiB 12639 MiB ± 174 MiB +0.91 %
10000_development-mode + rss memory 750 MiB ± 21.4 MiB 758 MiB ± 44.4 MiB +1.02 %
10000_development-mode_hmr + rss memory 1411 MiB ± 423 MiB 1605 MiB ± 339 MiB +13.77 %
10000_production-mode + rss memory 657 MiB ± 43.4 MiB 646 MiB ± 28 MiB -1.74 %
arco-pro_development-mode + rss memory 705 MiB ± 20.4 MiB 688 MiB ± 32.9 MiB -2.39 %
arco-pro_development-mode_hmr + rss memory 891 MiB ± 63.6 MiB 892 MiB ± 80.7 MiB +0.11 %
arco-pro_production-mode + rss memory 856 MiB ± 34.6 MiB 849 MiB ± 69.8 MiB -0.80 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 878 MiB ± 51.7 MiB 857 MiB ± 23.8 MiB -2.37 %
threejs_development-mode_10x + rss memory 784 MiB ± 49.3 MiB 805 MiB ± 39.9 MiB +2.67 %
threejs_development-mode_10x_hmr + rss memory 1588 MiB ± 139 MiB 1585 MiB ± 350 MiB -0.18 %
threejs_production-mode_10x + rss memory 1047 MiB ± 66.3 MiB 1049 MiB ± 78.6 MiB +0.16 %

@h-a-n-a h-a-n-a marked this pull request as ready for review November 27, 2024 06:19
@h-a-n-a h-a-n-a merged commit e747f7f into main Nov 27, 2024
44 checks passed
@h-a-n-a h-a-n-a deleted the perf-resolver branch November 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants