Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(incremental): get affected modules with chunk graph perf regression #8592

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(incremental): get affected modules with chunk graph perf regression #8592

merged 1 commit into from
Dec 2, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Dec 2, 2024 •
edited
Loading

Summary

I changed a par_iter to iter in last PR for better debugging and forgot change it back..

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk changed the title fix: get affected modules with chunk graph perf regression fix(incremental): get affected modules with chunk graph perf regression Dec 2, 2024
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 2, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bd04ca8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674da324d296f00008dcc5fd

@ahabhgk ahabhgk enabled auto-merge (squash) December 2, 2024 12:08
chenjiahan
chenjiahan reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PR description ⚠️

@ahabhgk ahabhgk merged commit 2ec1cf5 into main Dec 2, 2024
41 checks passed
@ahabhgk ahabhgk deleted the fix-perf-inc branch December 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@SyMind SyMind SyMind approved these changes

Assignees

@ahabhgk ahabhgk

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahabhgk @chenjiahan @SyMind