Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo #8607

Merged
merged 2 commits into from
Dec 4, 2024
Merged

docs: fix typo #8607

merged 2 commits into from
Dec 4, 2024

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Dec 3, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Dec 3, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f0a961b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674f0cdcf82acd00088e850c
😎 Deploy Preview https://deploy-preview-8607--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a h-a-n-a changed the title fix: typo docs: fix typo Dec 3, 2024
@github-actions github-actions bot added release: document release: document related release(mr only) and removed release: bug fix release: bug related release(mr only) labels Dec 3, 2024
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Dec 3, 2024 •
edited
Loading

Would you please fix the English translation as well?

@cbbfcd
Copy link
Contributor Author

cbbfcd commented Dec 3, 2024

Would you please fix the English translation as well?

👌

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

LingyuCoder
LingyuCoder approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@LingyuCoder LingyuCoder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you sign the CLA, and then this pr can be merged

@cbbfcd
Copy link
Contributor Author

cbbfcd commented Dec 4, 2024

Thanks, could you sign the CLA, and then this pr can be merged

@LingyuCoder ok, signed~

@h-a-n-a h-a-n-a merged commit 0bf7360 into web-infra-dev:main Dec 4, 2024
31 checks passed
@cbbfcd cbbfcd deleted the patch-1 branch December 4, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
release: document release: document related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbbfcd @h-a-n-a @CLAassistant @LingyuCoder