Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trusted type should add module runtime requirements #8617

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Dec 4, 2024

Summary

Relate to #8512

This pr fix the missing __webpack_require__ error. RuntimeGlobal.createScript should be added to module runtime requirements.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from ahabhgk December 4, 2024 05:47
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 29285ef
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674fecf024fecf00089e5054
😎 Deploy Preview https://deploy-preview-8617--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahabhgk ahabhgk merged commit 4cedd61 into main Dec 4, 2024
39 checks passed
@ahabhgk ahabhgk deleted the fix/trusted-type-runtime-requirements branch December 4, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants