Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: bump swc_core to 9.0.0 #8639

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Dec 6, 2024

Summary

swc_core 8 has breaking changes to the WASM interface for SWC plugins (swc-project/swc#9771), so we need to upgrade in order to use current SWC plugins.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 88c4d5b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675b379a5f0f4a0008edab02
😎 Deploy Preview https://deploy-preview-8639--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan
Copy link
Member

Thanks!

According to the Rspack version strategy, SWC's breaking changes will be included in the next Rspack minor version.

And we plan to release Rspack v1.2.0 this month. Rspack v1.2.0-alpha.0 should be released next week.

@chenjiahan chenjiahan added the release: breaking change release: breaking change related release(mr only) label Dec 9, 2024
@chenjiahan chenjiahan added this to the 1.2.0 milestone Dec 9, 2024
@chenjiahan
Copy link
Member

We plan to release Rspack 1.2.0 alpha.0 next week. @andersk can you resolve the conflicts so that we can merge this PR? ❤️

@GiveMe-A-Name GiveMe-A-Name self-requested a review December 12, 2024 09:54
@andersk andersk force-pushed the swc8 branch 2 times, most recently from 49b5120 to d25111d Compare December 12, 2024 10:16
@andersk andersk changed the title feat(core)!: bump swc_core to 8.0.1 feat(core)!: bump swc_core to 9.0.0 Dec 12, 2024
@andersk andersk force-pushed the swc8 branch 3 times, most recently from c458bd8 to cc56461 Compare December 12, 2024 18:25
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
Copy link
Contributor Author

andersk commented Dec 12, 2024

@chenjiahan Done, and bumped to 9.0.0.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@chenjiahan chenjiahan merged commit a313b28 into web-infra-dev:main Dec 13, 2024
32 checks passed
@chenjiahan
Copy link
Member

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 13, 2024

📝 Benchmark detail: Open

Name Base (2024-12-13 c81fa8d) Current Change
10000_big_production-mode_disable-minimize + exec 37.7 s ± 976 ms 37.6 s ± 524 ms -0.22 %
10000_development-mode + exec 1.79 s ± 21 ms 1.78 s ± 45 ms -0.23 %
10000_development-mode_hmr + exec 656 ms ± 7.9 ms 664 ms ± 18 ms +1.18 %
10000_production-mode + exec 2.33 s ± 42 ms 2.32 s ± 38 ms -0.34 %
arco-pro_development-mode + exec 1.74 s ± 73 ms 1.73 s ± 71 ms -0.21 %
arco-pro_development-mode_hmr + exec 379 ms ± 1.3 ms 379 ms ± 1.7 ms -0.02 %
arco-pro_production-mode + exec 3.11 s ± 87 ms 3.12 s ± 75 ms +0.19 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.17 s ± 78 ms 3.16 s ± 70 ms -0.13 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.12 s ± 93 ms 3.17 s ± 87 ms +1.57 %
threejs_development-mode_10x + exec 1.6 s ± 9.6 ms 1.58 s ± 19 ms -1.13 %
threejs_development-mode_10x_hmr + exec 789 ms ± 24 ms 773 ms ± 8.1 ms -2.02 %
threejs_production-mode_10x + exec 4.94 s ± 110 ms 4.91 s ± 44 ms -0.59 %
10000_big_production-mode_disable-minimize + rss memory 9737 MiB ± 290 MiB 9512 MiB ± 38.9 MiB -2.31 %
10000_development-mode + rss memory 808 MiB ± 16.8 MiB 841 MiB ± 69.2 MiB +4.09 %
10000_development-mode_hmr + rss memory 1906 MiB ± 321 MiB 1928 MiB ± 305 MiB +1.13 %
10000_production-mode + rss memory 699 MiB ± 38.9 MiB 695 MiB ± 57.2 MiB -0.54 %
arco-pro_development-mode + rss memory 732 MiB ± 47.1 MiB 715 MiB ± 27.9 MiB -2.37 %
arco-pro_development-mode_hmr + rss memory 825 MiB ± 19.7 MiB 780 MiB ± 126 MiB -5.49 %
arco-pro_production-mode + rss memory 792 MiB ± 69.8 MiB 810 MiB ± 58.9 MiB +2.23 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 815 MiB ± 54.2 MiB 827 MiB ± 55.3 MiB +1.44 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 841 MiB ± 32.3 MiB 819 MiB ± 48.2 MiB -2.67 %
threejs_development-mode_10x + rss memory 782 MiB ± 63.4 MiB 770 MiB ± 40.2 MiB -1.46 %
threejs_development-mode_10x_hmr + rss memory 1686 MiB ± 334 MiB 1580 MiB ± 209 MiB -6.27 %
threejs_production-mode_10x + rss memory 1103 MiB ± 83.2 MiB 1073 MiB ± 37.4 MiB -2.73 %

@andersk andersk deleted the swc8 branch December 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants