Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cli): remove Node.js semver checker #8855

Merged
merged 1 commit into from
Dec 26, 2024
Merged

perf(cli): remove Node.js semver checker #8855

merged 1 commit into from
Dec 26, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Since Rspack already uses the engines filed to limit the minimal Node.js version, it seems unnecessary to run semver to check the Node.js version at runtime.

Removing the semver() calls can make Rspack CLI 30~40ms faster in all cases.

Screenshot 2024-12-26 at 17 42 50

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Dec 26, 2024
Copy link

netlify bot commented Dec 26, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6a1eda5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676d25ed7dae0c0008ca51f4

Copy link

codspeed-hq bot commented Dec 26, 2024

CodSpeed Performance Report

Merging #8855 will not alter performance

Comparing cli_semver_1226 (6a1eda5) with main (7707956)

Summary

✅ 3 untouched benchmarks

@chenjiahan chenjiahan merged commit e074d28 into main Dec 26, 2024
36 checks passed
@chenjiahan chenjiahan deleted the cli_semver_1226 branch December 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants