Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align default options with JS #9116

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: align default options with JS #9116

merged 1 commit into from
Feb 7, 2025

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jan 24, 2025

Summary

This PR adds default option test. Default option of Compiler::builder should be aligned with JS.
This was done by comparing Rust options with JS options manually.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 24, 2025
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 89995f5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67a5bbddd9252800086cf33e

Copy link

codspeed-hq bot commented Jan 24, 2025

CodSpeed Performance Report

Merging #9116 will not alter performance

Comparing test-options (89995f5) with main (3fb1b39)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@h-a-n-a h-a-n-a marked this pull request as ready for review February 7, 2025 07:55
@h-a-n-a h-a-n-a changed the title test: add test for default option fix: align default options with JS Feb 7, 2025
@h-a-n-a h-a-n-a enabled auto-merge (squash) February 7, 2025 08:09
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 7, 2025
@h-a-n-a h-a-n-a merged commit 7c4ab28 into main Feb 7, 2025
35 checks passed
@h-a-n-a h-a-n-a deleted the test-options branch February 7, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants