Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct lazy compilation backend options schema #9138

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

chenjiahan
Copy link
Member

Summary

The zod schema for the lazyCompilation.backend configuration is out of date and this PR updates the schema to match with the type declaration.

See: https://rspack.dev/config/experiments#experimentslazycompilation

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8985de0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6799ff50a94f11000821b1c9

@chenjiahan chenjiahan requested a review from JSerFeng January 29, 2025 10:34
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #9138 will not alter performance

Comparing lazy_compilation_schema_0129 (8985de0) with main (cc5e3f6)

Summary

✅ 6 untouched benchmarks

@chenjiahan chenjiahan requested a review from hardfist January 29, 2025 11:45
@JSerFeng JSerFeng merged commit 3c2ab03 into main Feb 5, 2025
34 checks passed
@JSerFeng JSerFeng deleted the lazy_compilation_schema_0129 branch February 5, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants