Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore generator options for asset/source module type #9216

Conversation

haocheng6
Copy link
Contributor

Summary

Fixes #8604

For the asset/source module type, the generator options will not used and therefore can be safely ignored in the config adapter.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 9, 2025
Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a0e494
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67a93e327ec2fe0008940772

Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #9216 will not alter performance

Comparing haocheng6:fix/8604-ignore-generator-options-for-asset-source-type (3a0e494) with main (09af1d8)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@chenjiahan chenjiahan requested a review from ahabhgk February 10, 2025 02:34
@ahabhgk ahabhgk merged commit 9f8cd9d into web-infra-dev:main Feb 10, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Asset Module asset/source cannot be used together with dataUrl
2 participants