Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove socialLinks twitter in redirect and document #1812

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Feb 5, 2025

Summary

type IconName = keyof typeof presetIcons;

because of #1788, we have already remove 'twitter' type... so just remove it completely

Related Issue

#1788

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 6e66f15
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67a32c60a72b4c00086bbd81
😎 Deploy Preview https://deploy-preview-1812--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title fix: remove twitter icon in redirect and document fix: remove socialLinks twitter in redirect and document Feb 5, 2025
@SoonIter SoonIter merged commit 1f8078a into main Feb 5, 2025
9 checks passed
@SoonIter SoonIter deleted the remove-twitter branch February 5, 2025 09:41
@chenjiahan chenjiahan mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants