Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll-driven-animations.dist.yml #1002

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 29, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Apr 29, 2024
@foolip foolip mentioned this pull request Apr 29, 2024
Comment on lines +35 to +36
# Later addition (Chrome 116)
# - css.properties.timeline-scope
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to be convinced on this. What's the case for pulling this one out, when they landed just four weeks apart?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://chromestatus.com/feature/6752840701706240 says 115 and I expect caniuse would say 115 too if it was added. One bit of an API coming a release later is pretty common I think. Unless it's a terrible accident and the feature is unusable without that bit, I think #979 is the way to handle such cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @bramus can share some insights about whether the timeline-scope property is a vital part of scroll-driven-animations, or whether the feature is mostly usable without it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeline-scope is there for when want to animate an element based on a scroller that is not a parent of the animated element.

In most cases though, the animation subject is a child of the scroller – I’ve only used timeline-scope a few times in my demos.

@ddbeck ddbeck merged commit 6272cfa into web-platform-dx:main Apr 30, 2024
3 checks passed
@foolip foolip deleted the dist-scroll-driven-animations branch April 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants