Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <ins> and <del> elements #1435

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Add <ins> and <del> elements #1435

merged 8 commits into from
Jul 30, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 16, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
@petele
Copy link
Collaborator Author

petele commented Jul 16, 2024

Build error: api.HTMLModElement is used in both del and ins

Since they're somewhat different rendering and semantic meaning, I split them into two elements... But they both share the API. We could merge them back, but seems like maybe not the best option. Open to suggestions on how to proceed here.

@foolip
Copy link
Collaborator

foolip commented Jul 18, 2024

@petele I suggest stick the keys in <del> and adding a TODO pointing to #1173 for <ins>.

@petele petele requested a review from foolip July 30, 2024 13:40
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligning descriptions with #1403.

features/del.yml Outdated Show resolved Hide resolved
features/ins.yml Outdated Show resolved Hide resolved
@foolip foolip enabled auto-merge (squash) July 30, 2024 16:52
@foolip foolip merged commit beae98e into web-platform-dx:main Jul 30, 2024
3 checks passed
@petele petele deleted the elem-del branch August 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants