Add more keys to ARIA attribute reflection #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
autonome
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Generally in favor of this approach.
-
Agree on the computed state, b/c there's so much Safari stuff from 16 onward.
-
AOM will move slowly and come in pieces. I do think we should get someone deeply involved in that to help determine how the new features should be structured in advance of it shipping. But that's futurework not todaywork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1751
See the draft file: https://github.com/web-platform-dx/web-features/blob/main/features/draft/spec/wai-aria-1-3.yml
@autonome did some good research in #1751 (comment). With this PR, I'm proposing to stuff everything into the current ARIA reflection feature and move on.
I've used Element/ElementInternals.role to compute the status.
Future selves can revisit this feature and splits things out.