Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds background features and updates keys on existing background features #2206

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Adds background features and updates keys on existing background features #2206

merged 10 commits into from
Nov 13, 2024

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Nov 11, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 11, 2024
ddbeck
ddbeck approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. I have some optional description suggestions, but this is ready to merge.

features/background-origin.yml Outdated Show resolved Hide resolved
features/background-position.yml Outdated Show resolved Hide resolved
@vwallen @ddbeck
Apply suggestions from code review
a3090d3 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@ddbeck ddbeck merged commit 75576e0 into web-platform-dx:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwallen @ddbeck