Adds features from CSS 2 (@charset, float & clear, vertical-align) #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
vwallen
commented
Nov 12, 2024
Comment on lines
+69
to
+80
| - css.properties.border-collapse | ||
| - css.properties.border-collapse.collapse | ||
| - css.properties.border-collapse.separate | ||
| - css.properties.border-spacing | ||
| - css.properties.caption-side | ||
| - css.properties.caption-side.bottom | ||
| - css.properties.caption-side.bottom-outside | ||
| - css.properties.caption-side.top | ||
| - css.properties.caption-side.top-outside | ||
| - css.properties.caption-side.writing-mode_relative_values | ||
| - css.properties.empty-cells | ||
| - css.properties.table-layout |
There was a problem hiding this comment.
These CSS properties apply specifically to table elements or sub-elements. They could conceivably be split into a table styles feature or two features, related to border styles and caption styles. This seemed the most straightforward
ddbeck
approved these changes
Nov 14, 2024
|
@vwallen This looks good, but does need conflicts resolved to merge. Thank you! |
…into css-22 # Conflicts: # features/table.yml.dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.